feat: add JointCommand.msg for semantic forward control#304
Open
ShahazadAbdulla wants to merge 1 commit intoros-controls:masterfrom
Open
feat: add JointCommand.msg for semantic forward control#304ShahazadAbdulla wants to merge 1 commit intoros-controls:masterfrom
ShahazadAbdulla wants to merge 1 commit intoros-controls:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces
JointCommand.msgtocontrol_msgs. This provides a timestamped, semantically clear alternative to the deprecatedstd_msgs/Float64MultiArraycurrently utilized inforward_command_controller.Justification & Context
Float64MultiArraylacks a header stamp, which prevents the implementation of watchdog mechanisms. This new message includes astd_msgs/Headerto unblock safety timeouts (referencingros-controls/ros2_controllers#95).ros-controls/ros2_controllers#1913), the genericforward_command_controllerrequires a way to identify command types dynamically. Theinterface_namefield explicitly defines whether a command is for position, velocity, effort, etc., without requiring a "message explosion" of unique types.std_msgsandexample_interfacesusage tracked inros-controls/ros2_controllers#157andgz_ros2_control#292.Contribution Checklist
pre-commitlinters (ament_lint_cmake, ament_copyright, etc.).ros2 interface show.Message Structure
std_msgs/Header header: Timestamp for watchdog/timeout logic.string[] joint_names: Explicit targeting of joints.string interface_name: Defines the interface (e.g., "position", "velocity").float64[] values: The commanded values.Once merged, I will submit the corresponding PR in
ros2_controllersto integrate this message and implement the safety watchdog logic.