GenMC: Don't split up non-atomic accesses to smaller chunks#4956
Merged
RalfJung merged 1 commit intorust-lang:masterfrom Apr 13, 2026
Merged
GenMC: Don't split up non-atomic accesses to smaller chunks#4956RalfJung merged 1 commit intorust-lang:masterfrom
RalfJung merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-author
Collaborator
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
rustbot
added
S-waiting-on-review
Member
|
Nice :) |
RalfJung
reviewed
Apr 13, 2026
Member
There was a problem hiding this comment.
Actually I just realized this test doesn't turn on GenMC mode. 😂
Member
There was a problem hiding this comment.
Maybe we should set -Zmiri-genmc automatically for tests in that folder, though this could be tricky to implement in our test runner.
Contributor
Author
There was a problem hiding this comment.
Nah, it's my fault for copy-pasting test code left and right :-)
Member
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
GenMC is now able to handle larger and mixed-size non-atomic accesses.
michaliskok
force-pushed
the
genmc-no-split-nas
branch
from
400f5c2 to
6d7340d
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenMC is now able to handle larger and mixed-size non-atomic accesses. (Follow up on #4949).
This deals with one of the checkmarks in #4572.
r? @RalfJung