Skip to content

Hotfix license bug#112

Open
mscasso-scanoss wants to merge 1 commit intomainfrom
5.4.25
Open

Hotfix license bug#112
mscasso-scanoss wants to merge 1 commit intomainfrom
5.4.25

Conversation

@mscasso-scanoss
Copy link
Copy Markdown
Contributor

@mscasso-scanoss mscasso-scanoss commented Apr 12, 2026

Summary by CodeRabbit

  • Chores

    • Updated version to 5.4.25
  • Bug Fixes

    • Improved license processing efficiency by deferring unnecessary operations during loop iterations

@mscasso-scanoss mscasso-scanoss self-assigned this Apr 12, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d93d6d3e-8f96-4d33-8663-87cbef35f027

📥 Commits

Reviewing files that changed from the base of the PR and between 6e658a3 and d883cef.

📒 Files selected for processing (2)
  • inc/scanoss.h
  • src/license.c

📝 Walkthrough

Walkthrough

Version increment from 5.4.24 to 5.4.25 and reordering of license processing logic in print_licenses to move JSON conversion after the early-exit condition check.

Changes

Cohort / File(s) Summary
Version Management
inc/scanoss.h
Bumped SCANOSS_VERSION macro from "5.4.24" to "5.4.25".
License Processing Logic
src/license.c
Reordered per-license loop processing in print_licenses: moved license_to_json() call to execute after the early-exit condition check, affecting when JSON conversion occurs relative to the last_id mismatch logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • 5.4.24 #111: Modifies the same print_licenses logic in src/license.c regarding early-exit and last_id handling.
  • 5.4.23 #110: Also bumps SCANOSS_VERSION macro in inc/scanoss.h.

Suggested reviewers

  • scanoss-qg

Poem

🐰 A tiny hop, a version's call,
From .24 to .25 we rise up tall,
License loops now dance anew,
Logic flows in order true! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'Hotfix license bug' is vague and generic, failing to convey the specific changes made (version bump to 5.4.25 and license processing fix). Provide a more specific title that describes the actual changes, such as 'Bump version to 5.4.25 and fix license processing order' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 5.4.25

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@scanoss-qg scanoss-qg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants