When possible, set the Accept header appropriately#542
Open
candrews wants to merge 2 commits intosockjs:mainfrom
Open
When possible, set the Accept header appropriately#542candrews wants to merge 2 commits intosockjs:mainfrom
candrews wants to merge 2 commits intosockjs:mainfrom
Conversation
When the transport supports doing so, set the "Accept" request header to an appropriate value. Doing so informs the server what type of response the client is expecting.
Author
|
The failing test is because the test doesn't have access to Travis secure variables: Line 7 in ddae5a3 It would pass if run by the main sockjs-client repo. |
Author
|
@brycekahle can you please take a look at this PR? |
Contributor
|
@candrews Apologies. I'll take a look at this soon. I just need to verify the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the transport supports doing so, set the "Accept" request header to
an appropriate value. Doing so informs the server what type of response
the client is expecting.
Closes #540