Rotated refresh token uses the expiry of initial refresh token#2320
Open
kpur-sbab wants to merge 1 commit intospring-projects:mainfrom
Open
Rotated refresh token uses the expiry of initial refresh token#2320kpur-sbab wants to merge 1 commit intospring-projects:mainfrom
kpur-sbab wants to merge 1 commit intospring-projects:mainfrom
Conversation
…xpiry timestamp from the initial refresh token Closes spring-projects#2318 Signed-off-by: Kishore <kishore.purushothaman@sbab.se>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Spring Authorization Server, when refresh token rotation is enabled, each newly issued refresh token receives a full TTL. As a result, if a refresh token is rotated close to its expiry, the new token effectively resets its lifetime. This behavior appears to violate the #297 stated guideline and could introduce a potential security concern.
The fix is to make the changes in OAuth2RefreshTokenGenerator to enable this support by reusing the expiry from the context's authorization model