Open
Conversation
The `datetime.datetime.strptime` function will only return naive timestamps, and those will crash in the database query later if run during times when DST is changing. It can crash with `NonExistantTimeError` when the clock moves forward, and with `AmbiguousTimeError` when the clock moves back. Since we know(?) that we always provide a "UTC" suffix to these timestamps, I think it is safe to hardcode that we add the `timezone.utc` as the tzinfo to these parsed objects.
Frost
force-pushed
the
fix-service-view-date-parse
branch
from
ad63350 to
06b34d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
datetime.datetime.strptimefunction will only return naive timestamps, and those will crash in the database query later if run during times when DST is changing. It can crash withNonExistantTimeErrorwhen the clock moves forward, and withAmbiguousTimeErrorwhen the clock moves back.Since we know(?) that we always provide a "UTC" suffix to these timestamps, I think it is safe to hardcode that we add the
timezone.utcas the tzinfo to these parsed objects.