Conversation
The Garmin / usb-storage code uses a bunch of POSIX functions that need Windows workarounds. Also, msvc throws up on arrays of structures with variable fields. So work around that. And the vcxproj file was of course missing the new files that we had added for our fork. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Signed-off-by: Michael Keller <github@ike.ch>
Signed-off-by: Michael Keller <github@ike.ch>
We can't do this the way it was done with gcc/clang as that exploited an extension that isn't available in msvc; but this should work on all of the compilers and do fundamentally the same thing. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
Is this still needed? |
|
apparently not. I'm not quite sure why I needed the changes to garmin_parser.c -- or more likely which settings I was missing when I did this locally that prevented the existing code from working and caused me to need the changes in this PR, but since the GitHub Action appears to successfully build libdc without these changes, I guess... 🤷🏼♂️ The bigger issue for Garmin is that we don't have a working libmtp for Windows/msvc - but that has nothing to do with this PR. |
Ouch, yes, that would be a loss, even more so as Garmin is only supported on desktop. How ugly will it get if we have to use the native Windows MTP API? |
2 participants
trying to see if copilot will offer a review if I open the PR from a different repo