intel: boards: uaol: Temporarily disable UAOL#10670
intel: boards: uaol: Temporarily disable UAOL#10670serhiy-katsyuba-intel wants to merge 1 commit intothesofproject:mainfrom
Conversation
On Linux platforms, enabling UAOL leads crash. See SOFC2-1595. This temporarily disables UAOL until a proper fix is merged. Since the proper fix might be on the Zephyr side, it could take quite a lot of time until the fix is merged and west.yml is updated. Hence this quick workaround to unblock CI and not worsen the developer experience. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull request overview
Temporarily disables UAOL by default for Intel ADSP boards to avoid Linux crashes (SOFC2-1595) and unblock CI until an upstream fix lands.
Changes:
- Change
CONFIG_UAOLdefault from enabled (whenACE) to disabled. - Add an inline note referencing SOFC2-1595 and comment out the prior default line.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| default n # Temporarily disabled until a proper fix for SOFC2-1595 is merged. | ||
| # default y if ACE |
There was a problem hiding this comment.
The PR description says the crash happens on Linux, but this change disables UAOL unconditionally for all builds of this board defconfig. If the unconditional disable is intentional (e.g., there’s no Kconfig symbol to key off host OS), please clarify that in the comment/PR description; otherwise consider disabling only for the affected condition.
Also, keeping the old default y if ACE as a commented-out Kconfig line is a bit confusing and is inconsistent with other board config fragments in this repo (no other #\tdefault ... occurrences under app/boards). Prefer removing it and capturing the prior behavior in a regular comment instead.
|
Alternative approach: #10672 |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
I'm good with this or alternatively #10672 Let's see which is in mergeable state sooner. 10672 does have the benefit we can keep testing UAOL in Intel internal CI with SOF main...
We don't normally refer to internal bugs in git commits, but given this only for an Intel board file, less of an issue...
On Linux platforms, enabling UAOL leads crash. See SOFC2-1595. This temporarily disables UAOL until a proper fix is merged. Since the proper fix might be on the Zephyr side, it could take quite a lot of time until the fix is merged and west.yml is updated. Hence this quick workaround to unblock CI and not worsen the developer experience.