Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughVersion bumps applied to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI release metadata and dependency set, adjusts the build pipeline to drop the UMD target, and refines dist package generation to include both dependency types.
Changes:
- Bump
@tsparticles/cliversion to3.4.2and update related config/tooling dependencies (plus lockfile refresh). - Remove the UMD TypeScript build configuration/target from the build flow and template.
- Ensure
package.dist.jsongeneration can include bothdependenciesandpeerDependencies.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/build/build-tsc.ts | Removes the umd compile target from the TS build switch/types list. |
| src/build/build-distfiles.ts | Allows emitting both dependencies and peerDependencies into package.dist.json. |
| package.json | Bumps CLI version and updates dependency versions. |
| pnpm-lock.yaml | Lockfile refresh to reflect updated dependencies. |
| files/empty-project/tsconfig.umd.json | Removes the UMD tsconfig from the empty project template. |
| files/empty-project/package.json | Updates template devDependency versions to match new config/tooling versions. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| type: "browser" | "cjs" | "esm" | "types" | "umd", | ||
| silent: boolean, | ||
| ): Promise<number> { | ||
| async function compile(basePath: string, type: "browser" | "cjs" | "esm" | "types", silent: boolean): Promise<number> { |
There was a problem hiding this comment.
The PR title suggests a patch/version-only update, but this change removes UMD build support (the umd build type and its generated dist/umd output). If users rely on the UMD artifact, this is a behavior/breaking change—please document it in the PR description/release notes and consider whether the version bump should reflect the change (e.g., at least a minor version depending on your semver policy).
Summary by CodeRabbit
3.4.2.