Skip to content

fix: Update s3 extension logic to handle "__all__" (off-ticket)#1256

Draft
alexlescionok wants to merge 1 commit intomainfrom
handling_all_s3_extensions
Draft

fix: Update s3 extension logic to handle "__all__" (off-ticket)#1256
alexlescionok wants to merge 1 commit intomainfrom
handling_all_s3_extensions

Conversation

@alexlescionok
Copy link
Copy Markdown
Contributor

@alexlescionok alexlescionok commented Feb 5, 2026

WHY

Observed behaviour: The extensions config only successfully applies when ensuring __all__ is in a list of strings, not as a string.

The terraform apply falls over if platform-config.yml contains:

services: __all__

Platform-helper schema validation shows we can add a string of __all__ OR a list of strings.

TESTING

Temporary locals for testing all logic in terraform console confirms the observed behaviour.

ECS-Services module has Terraform logic that uses contains function that expects a list of strings and not just a string.

Existing platform-helper logic does not catch this until we reach the terraform apply.


Checklist:

Title:

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • If the work includes user interface changes, before and after screenshots included in description
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

Reviewer Checklist

  • I have reviewed the PR and ensured no secret values are present

@alexlescionok alexlescionok requested a review from a team as a code owner February 5, 2026 10:58
@alexlescionok alexlescionok marked this pull request as draft February 5, 2026 10:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

Your PR has commits that are missing the Signed-off-by trailer. This is likely due to the pre-commit hook not being configured on your local machine. The usual fix for this issue is to run pre-commit install --install-hooks --overwrite -t commit-msg -t pre-commit, however for more detailed help in setting up the pre-commit hooks, follow the instructions at https://github.com/uktrade/github-standards/blob/main/README.md#usage

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

⚠️ Python Vulnerabilities detected: 1 unique issues.

Low:

@alexlescionok alexlescionok changed the title fix: update s3 extension logic to handle "__all__" (off-ticket) fix: Update s3 extension logic to handle "__all__" (off-ticket) Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant