fix: Update s3 extension logic to handle "__all__" (off-ticket)#1256
Draft
alexlescionok wants to merge 1 commit intomainfrom
Draft
fix: Update s3 extension logic to handle "__all__" (off-ticket)#1256alexlescionok wants to merge 1 commit intomainfrom
alexlescionok wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Your PR has commits that are missing the Signed-off-by trailer. This is likely due to the pre-commit hook not being configured on your local machine. The usual fix for this issue is to run |
Contributor
|
Low:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
Observed behaviour: The extensions config only successfully applies when ensuring
__all__is in a list of strings, not as a string.The terraform apply falls over if platform-config.yml contains:
Platform-helper schema validation shows we can add a string of
__all__OR a list of strings.TESTING
Temporary locals for testing all logic in terraform console confirms the observed behaviour.
ECS-Services module has Terraform logic that uses
containsfunction that expects a list of strings and not just a string.Existing platform-helper logic does not catch this until we reach the terraform apply.
Checklist:
Title:
feat: Add new feature (DBTP-1234)orchore: Correct typo (off-ticket)Description:
Tasks:
Reviewer Checklist