fix(bootstrap): move CRD filter out of helmfile postRenderer for helm 4 compat#257
Merged
fix(bootstrap): move CRD filter out of helmfile postRenderer for helm 4 compat#257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Helm 4 removed support for arbitrary binaries as
--post-renderer; it now only accepts plugins of typepostrenderer/v1.bootstrap/helmfile.d/00-crds.yamlusedpostRenderer: bash+postRendererArgs: [-c, yq eval-all ...]to filter rendered manifests down to CRDs, which fails on helm 4 with:```
Error: invalid argument "bash" for "--post-renderer" flag: plugin: {Name:bash Type:postrenderer/v1} not found
```
This change moves the yq filter out of helmfile's `postRenderer` and into the shell pipeline in `scripts/bootstrap-apps.sh`, keeping behavior identical on helm 3 while unblocking #222 (aqua:helm/helm 3.20.2 → 4.1.4).
Changes
Validation
Three-way test on live OCI charts (cloudflare-dns, envoy-gateway, kube-prometheus-stack) at the versions currently pinned in `00-crds.yaml`:
Helm 4.1.4 was sourced via `mise exec aqua:helm/helm@4.1.4`. Both helmfile `template` calls succeed; 01-apps.yaml also renders cleanly under helm 4 with no changes required.
Scope / blast radius
Unverified
Follow-up
Once this merges, #222 (aqua:helm/helm 3.20.2 → 4.1.4) should be safe to merge.
Test plan