DO NOT MERGE: FastLoad is working, both anonymized and un-anonymized#133
Open
SailingSteve wants to merge 2 commits intowevote:developfrom
Open
DO NOT MERGE: FastLoad is working, both anonymized and un-anonymized#133SailingSteve wants to merge 2 commits intowevote:developfrom
SailingSteve wants to merge 2 commits intowevote:developfrom
Conversation
Fixed the logic to see if un-anonymized was being requested. In anonymized now skips anonymizing rows that have ['deprecate', 'do-not-reply', 'donotreply', 'delete'] in their data -- these rows are for testing, or to be deleted in production, and were messing up anonymization for the Person.emailPersonal primary key, which needs to be unique. The uniqueNamesGenerator() library returns random names from a internal dictionary, and can return dupes within a session, so set up a way to guarantee that they are unique, so we don't have primary key errors on update. There is a lot of loggin in this feature, but it is rarely used, and the logging gives us a better chance of solving future data problems with CloudWatch.
SailingSteve
changed the title
Fixed the logic to see if un-anonymized was being requested. In anonymized now skips anonymizing rows that have ['deprecate', 'do-not-reply', 'donotreply', 'delete'] in their data -- these rows are for testing, or to be deleted in production, and were messing up anonymization for the Person.emailPersonal primary key, which needs to be unique. The uniqueNamesGenerator() library returns random names from a internal dictionary, and can return dupes within a session, so set up a way to guarantee that they are unique, so we don't have primary key errors on update. There is a lot of loggin in this feature, but it is rarely used, and the logging gives us a better chance of solving future data problems with CloudWatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4/5/26: Works for all tables except TeamMember, which has foreign keys that need special attention.
Fixed the logic to determine if un-anonymized data is being requested.
In "anonymized", now skips anonymizing rows that have ['deprecate', 'do-not-reply', 'donotreply', 'delete'] in their data -- these rows are for testing, or to-be-deleted in production, and were messing up anonymization for the Person.emailPersonal primary key, which needs to be unique.
The uniqueNamesGenerator() library returns random names from a internal dictionary, and can return dupes within a session, so set up a way to guarantee that they are unique, so we don't have primary key errors on update.
There is a lot of logging in this feature, but the feature is rarely used, and the logging gives us a better chance of understanding future data problems via CloudWatch.