add OIDC SSO authentication mode via activeadmin-oidc#1980
Merged
dmitry-sinina merged 6 commits intomasterfrom Apr 10, 2026
Merged
add OIDC SSO authentication mode via activeadmin-oidc#1980dmitry-sinina merged 6 commits intomasterfrom
dmitry-sinina merged 6 commits intomasterfrom
Conversation
- Add AdminUserOidcHandler concern (omniauthable + trackable + ip_allowable, password auth disabled via valid_password? returning false) - File-gated mode selection: config/oidc.yml > config/ldap.yml > database - AdminUser.external_auth? helper replaces ldap?-only guards in admin UI - on_login hook filters IdP roles against AdminUser.available_roles, falls back to default_roles, denies login when no role matches - Migration adds provider, uid, oidc_raw_info columns + partial unique index - Login view conditionally hides password form in OIDC mode, uses form_tag + submit_tag for SSO button to match ActiveAdmin theme CSS - Gem sourced from github: activeadmin-plugins/activeadmin-oidc
…O issue - Fix Bundler/OrderedGems and Layout offenses - Fix valid_password? override shadowed by Devise MRO (use define_method after devise call) - Fix .configuration -> .config typo in OIDC feature specs - Fix route spec to use actual request instead of route_to matcher - Fix admin_users_form spec to use string paths instead of missing helpers - Fix initializer spec: stub AdminUser.available_roles, add persisted?/enabled? doubles - Remove admin_user_class test (initializer no longer sets it)
Contributor
Author
|
Remove manual OmniAuth strategy registration, view path overrides, and test stubs — all now handled by the activeadmin-oidc gem's engine and built-in test helpers.
…dmin The on_login lambda intersects IdP-claimed roles with AdminUser.available_roles (root, user, reporter). Using admin caused empty intersection and login denial.
- Use RFC-compliant test emails (alice@test.com instead of alice@test) to pass AdminUser email format validation - Fix admin_users_form_spec URLs: yeti-web uses root namespace so paths are /admin_users not /admin/admin_users - Update gem to d6dbc83 which fixes OmniAuth 2.x CSRF check in test mode stubs
dmitry-sinina
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.