Draft
Conversation
Member
xepozz
commented
Apr 7, 2023
xepozz
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
============================================
- Coverage 88.44% 88.36% -0.09%
+ Complexity 95 93 -2
============================================
Files 13 13
Lines 277 275 -2
============================================
- Hits 245 243 -2
Misses 32 32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Overall the change looks OK. Need a CHANGELOG for it. Also, it's is backwards compatibility breaking one. |
rustamwin
approved these changes
Jun 30, 2023
vjik
requested changes
Jul 1, 2023
Comment on lines
-31
to
-34
| if ($this->currentUser->isGuest()) { | ||
| return null; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
It's break logic of Yii Auth package in Authentication middleware: https://github.com/yiisoft/auth/blob/27a4e9ac4e89d810625c73f1578586d2ecdc9c27/src/Middleware/Authentication.php#L48C43-L48C53
Member
Author
|
It shouldn't be merged yet because it cause bugs in authentication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.