changed bottom ui; Using fa-icons know#23
Open
pythongiant wants to merge 4 commits intoyogdaan:masterfrom
Open
changed bottom ui; Using fa-icons know#23pythongiant wants to merge 4 commits intoyogdaan:masterfrom
pythongiant wants to merge 4 commits intoyogdaan:masterfrom
Conversation
Member
|
please post a simple screenshot. |
Member
Author
|
Nothing to worry about in the same 2 files above. Just messed up my workflow a bit |
Member
|
@pythongiant good work but do you know the negative impact of your changes ? its a simple light webpage now the loading time will increase cause we are requesting another server for the fonts either we make them local in the repo ( then we need to do some benchmarking to check what takes more time SVG or these fonts ) |
Member
Author
|
sure @xeon-zolt I am okay with whatever the benchmarks show. |
ParthS007
reviewed
Aug 5, 2018
Member
ParthS007
left a comment
ParthS007
left a comment
There was a problem hiding this comment.
@pythongiant Please resolve conflicts 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using fa-icons know in place of previous SVGs, added animations and changed color of the bottom nav, added rel="icon" to webpage
