Omni wheel drive odometry update#2286
Open
Devdoot57 wants to merge 4 commits intoros-controls:masterfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2286 +/- ##
==========================================
- Coverage 84.72% 84.65% -0.08%
==========================================
Files 153 154 +1
Lines 15362 15421 +59
Branches 1332 1334 +2
==========================================
+ Hits 13016 13054 +38
- Misses 1858 1878 +20
- Partials 488 489 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
omni_wheel_drive_controllerodometry implementation to usedouble dtfor integration instead of relying onrclcpp::Time(matching #1854). It also introduces a comprehensivegtestsuite to verify the holonomic kinematics and integration math (matching #2099).This rolls out the architectural improvements requested in #2039 for the omni-wheel base.
Changes:
updateFromPos,updateFromVel, andupdateOpenLoop. Replaced withupdate_from_pos,update_from_vel, andtry_update_open_loop.test_odometry.cppcovering:dtrejection.